-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCons: Fix compilation database generation with MSVC #65440
Conversation
The
|
The platform/windows/detect.py change may have been specific to the issue I was having when my visual studio was installed incorrectly. At first I did not supply that argument, but still always mingw was selected. I started supplying the msvc_version=14.2 to force it, which it then still was selecting mingw. So when I made that change to detect.py then it forced msvc selection and I saw my msvc install was corrupt and then I fixed the msvc install. That change in platform/windows/detect.py should be reverted. SCons will set the MSVC_VERSION internally if your MSVC install is valid (My case it wasn't so it wasn't setting MSVC_VERSION internally). Although if |
I used the patch of this PR against master, using SCons: v4.3.0.559790274f66fa55251f5754de34820a29c7327a and it was successful in creating the It is still not useful for my work, because I need the full build info (link commands etc.) but it does seem to fix the |
Fixes godotengine#54434. Co-authored-by: Daniel Moody <daniel.moody@mongodb.com>
680d77d
to
22381d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test it right now, but moving it after toolchain setup seems like a right way to go.
Cherry-picked for 3.6. |
Cherry-picked for 3.5.1. |
Fixes #54434.
Co-authored-by: @dmoody256
Didn't get to test it myself, would be great if a few MSVC users could confirm it works (to enable compilation database generation, you should pass
compiledb=yes
to SCons).